Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucijs backend home page #484

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Lucijs backend home page #484

wants to merge 9 commits into from

Conversation

lucijs
Copy link
Contributor

@lucijs lucijs commented Jan 25, 2025

Samo san fatchala sve eventove i ovih 5 najbolje ocijenjenih kompanija, testirala san lokalno i sve radi

@lucijs lucijs requested review from dbaric99 and lovretomic January 25, 2025 22:05
@lucijs lucijs linked an issue Jan 25, 2025 that may be closed by this pull request
Copy link
Contributor

@dbaric99 dbaric99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Osim nacina tj mista di fetchas podatke ostalo mi sve izgleda dobro 👍🏼

import RecommendationsButton from '../../../../components/RecommendationsButton';
import { CompanyPublicDto } from '@ddays-app/types';

async function fetchTopRatedCompanies(): Promise<CompanyPublicDto[] | undefined> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nebi fetchala podatke direkt u komponentama, mozes izvuc ove stvari u custom hookove po potrebi ako su podaci potrebni na vise mista napravit provider

@lucijs lucijs requested a review from dbaric99 January 28, 2025 21:17
Copy link
Member

@lovretomic lovretomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ajde pliz samo pogledaj ovo i rjesi da bude spremno, ako nisi opet mergeaj main i provjeri zasto se ruse checkovi pa rerequestaj review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge markeri ostali? nesto se skrsilo kod konflikata

@lucijs lucijs requested a review from lovretomic March 19, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend: Home Page
3 participants