Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scope repo for oauth with Github #184

Closed
wants to merge 1 commit into from
Closed

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Mar 3, 2022

ref: #182

This PR add manually the "repo" scope which gives read/write access to repository when using oauth token.

@SimonLab SimonLab temporarily deployed to dwylauth March 3, 2022 15:13 Inactive
@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #184 (6d5c372) into main (e121667) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          586       586           
=========================================
  Hits           586       586           
Impacted Files Coverage Δ
lib/auth_web/controllers/auth_controller.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e121667...6d5c372. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab this scope is only desirable for the labels App. We don't need it for our Main app. 💭

@SimonLab
Copy link
Member Author

SimonLab commented Mar 4, 2022

Indeed this is not a perfect solution as it changed the scope for all the applications created with auth.
I'll add checkboxes in the UI when creating a new app to select which scope to add

@SimonLab SimonLab closed this Mar 4, 2022
@SimonLab SimonLab deleted the github-repo-scope branch March 4, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants