feat: add localized random greetings after sign-in#146
Open
Conversation
Add a login-success listener that flashes a random greeting translation key so users see a one-time localized nerd-humor greeting on the first page after authentication. Include provider, listener, and functional/unit tests to verify key selection, event handling, and flash consumption behavior.
Member
|
The quality checks do not pass. |
Tighten session and greeting key typing so the login greeting listener and tests satisfy PHPStan and project standards, restoring a passing quality pipeline for the feature branch.
Member
|
Please make another round of code improvements. See where you can improve overall implementation quality. |
Centralize greeting metadata and skip non-redirect login responses so flashes stay scoped to browser navigation flows. Derive functional greeting assertions from provider keys and translations to keep tests aligned with localized content changes.
Member
|
Please add feature documentation! |
Guard greeting flashes to HTML login contexts only, make greeting assertions more robust via typed flash metadata, and document the full post-sign-in greeting flow for maintainability.
Member
|
Please add more technical details to the documentation. |
Prevent duplicate sign-in greeting flashes during multi-handler login paths and document the feature with event-level guard details for maintainability. Also refactor edit-session chunk handling to satisfy PHPStan so quality checks pass reliably.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoginSuccessEventlistener that flashes one randomauth.greeting.*key for successful logins on themainfirewall.auth_greetingflash type throughtranson first-page flash output.Test plan
mise run testsmise run tests:frontendmise run frontendmise run quality(fails in this workspace due existing lint issues in.productbuilder-runtimeartifacts unrelated to this change)Closes #145