This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
speed up get_packages by adding shortcut in has
function
#1841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if anyone else is suffering from the same issue. On my WSL 2, it takes 4 seconds and more to run neofetch. Most of the time is consumed by
get_pacakges
.After investigation into the code. I think it unnecessary to try reaching all the possible package managers -- it would be a large bunch of disk operation.
So I add a shortcut in the
has
function -- once the variable$manager
is set, all the following check ofhas
would return false. That is, it will just take the first package manager it sees as the answer.This simple modification makes significant improvement on my machine:
Before modification:
It takes 4.298 seconds in total.
After modification:
It takes 0.900 seconds in total.