Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eibc): add ability to find fulfiller on demand #1745

Open
wants to merge 28 commits into
base: upgrading_to_v50
Choose a base branch
from
Open

feat(eibc): add ability to find fulfiller on demand #1745

wants to merge 28 commits into from
+5,265 −248

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Feb 20, 2025 •
edited
Loading

Description

Still need to update import/export genesis for eibc module

https://www.notion.so/dymension/ADR-Trigger-Fulfillment-19fa4a51f86a8069abdaf1dea2e0f732

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

danwt
danwt commented Feb 21, 2025
View reviewed changes
x/eibc/keeper/keeper.go
@@ -149,6 +165,28 @@ func (k Keeper) GetDemandOrder(ctx sdk.Context, status commontypes.Status, id st
return &order, nil
}

func (k Keeper) GetOutstandingOrder(ctx sdk.Context, orderId string) (*types.DemandOrder, error) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved

danwt
danwt commented Feb 21, 2025
View reviewed changes
x/eibc/keeper/keeper.go
@@ -242,6 +280,31 @@ func (k Keeper) ListDemandOrdersByStatusPaginated(
return
}

func (k Keeper) Fulfill(ctx sdk.Context,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted and reused

@danwt danwt changed the title Danwt/find fulfiller feat(eibc): add ability to find fulfiller on demand Feb 21, 2025
@danwt danwt marked this pull request as ready for review February 21, 2025 14:02
@danwt danwt requested a review from a team as a code owner February 21, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danwt