refactor(submit): simplified submit loop #1331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srene
reviewed
Jan 24, 2025
| @@ -55,47 +55,60 @@ func SubmitLoopInner( | |||
| maxBatchSubmitBytes uint64, // max size of serialised batch in bytes | |||
There was a problem hiding this comment.
isLastBatchRecent must be removed if not used
srene
reviewed
Jan 24, 2025
There was a problem hiding this comment.
im thinking this approach may have a flaw. i think that, if a node is restarted for instance 5 min before the next batch submission by time (e.g. batch time 1 hour), it will wait another hour before trying to submit by time, given the ticker is configured using maxBatchSubmitTime. i think in the current approach the ticker is activated more often, and then its checked whether is necessary to submit by time using isLastBatchRecent func. this way, even if a node is restarted, it will submit every 1 hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better role separation between
triggerandsubmitterroutines