feat(da): RetrieveBatchesV2 method #937
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keruch
changed the title
danwt
requested changes
Jul 4, 2024
Comment on lines
+38
to
+47
| if err != nil { | ||
| return types.Batch{}, fmt.Errorf("can't gunzip batch: %w", err) | ||
| } | ||
|
|
||
| // Prepare the blob data | ||
| var batch types.Batch | ||
| err = batch.UnmarshalBinary(binary) | ||
| if err != nil { | ||
| return types.Batch{}, fmt.Errorf("can't unmarshal batch: %w", err) | ||
| } |
There was a problem hiding this comment.
dont need 'can't in the messages
Comment on lines
+17
to
+33
| // Generate batches with random headers | ||
| expected := types.Batch{ | ||
| StartHeight: h1, | ||
| EndHeight: h2, | ||
| Blocks: []*types.Block{}, | ||
| Commits: []*types.Commit{}, | ||
| } | ||
|
|
||
| data, err := interchain.EncodeBatch(expected) | ||
| require.NoError(t, err) | ||
|
|
||
| actual, err := interchain.DecodeBatch(data) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, expected, actual) | ||
| }) | ||
| } |
There was a problem hiding this comment.
what exactly do you expect to reveal by only fuzzing the heights?
Co-authored-by: Daniel T <[email protected]>
Co-authored-by: zale144 <[email protected]>
Signed-off-by: yuhangcangqian <[email protected]>
Co-authored-by: zale144 <[email protected]>
Co-authored-by: danwt <[email protected]>
Co-authored-by: Omri <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Michael Tsitrin <[email protected]> Co-authored-by: Omri <[email protected]> Co-authored-by: Daniel T <[email protected]>
…mer to submitter thread (#1014)
Co-authored-by: Daniel T <[email protected]>
…of restart or crash) (#1045) Co-authored-by: Omri <[email protected]>
…v0.15 compatibility (#1047)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #930
This PR contains changes with respect to the generalized DA specification. This is the second part of the implementation following #929.
Changelog:
For Author:
godoccommentsFor Reviewer:
After reviewer approval: