Skip to content

fix: remove excessive metadata#776

Open
maksymbuleshnyi wants to merge 1 commit into
mainfrom
fix/remove-metadata-keys
Open

fix: remove excessive metadata#776
maksymbuleshnyi wants to merge 1 commit into
mainfrom
fix/remove-metadata-keys

Conversation

@maksymbuleshnyi

@maksymbuleshnyi maksymbuleshnyi commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes what is stored in memory and propagated to sub-agents; callers who relied on extra input fields in metadata will see different behavior.

Overview
Stops merging Pydantic extra fields from AgentInputSchema into the metadata dict built in _prepare_metadata.

Agent runs still copy input_data.metadata, strip leaked keys (files, images, tool_params), and add user_id / session_id when set. Arbitrary extra input properties are no longer folded into metadata used for _current_call_context, memory saves, and child-agent context. Extra fields continue to be available for prompt templating via model_dump(exclude=standard_fields) in execute().

Reviewed by Cursor Bugbot for commit 1ca3404. Bugbot is set up for automated code reviews on this repo. Configure here.

@maksymbuleshnyi maksymbuleshnyi requested a review from a team as a code owner June 10, 2026 15:13
@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
dynamiq/nodes/agents
   base.py105430670%62, 68, 160–162, 177, 185, 188, 332, 350, 360, 363, 406, 408, 439–441, 443–448, 453–455, 477–483, 487–492, 495–499, 511–512, 514–519, 521–522, 530, 546, 548, 550, 571–572, 587, 660–661, 665–668, 677–678, 688–691, 705–712, 720–722, 757, 768–769, 894, 897, 901–902, 926–942, 962, 966, 1007–1008, 1012–1013, 1026, 1067, 1099, 1110, 1134–1137, 1139, 1141, 1143–1145, 1147–1148, 1155, 1157–1158, 1162–1164, 1170, 1175, 1178–1180, 1201, 1203, 1221–1223, 1227–1229, 1232, 1244–1245, 1266–1271, 1288–1289, 1291–1292, 1296–1297, 1299–1306, 1309–1312, 1314–1315, 1317–1319, 1339, 1346–1347, 1352, 1369–1370, 1375, 1386–1388, 1399–1400, 1405, 1413, 1415, 1432, 1438, 1445, 1469, 1492–1493, 1509, 1516–1519, 1522, 1527, 1535, 1559, 1563–1564, 1591–1593, 1595–1600, 1602–1603, 1605–1613, 1620, 1622–1625, 1627–1635, 1642, 1644, 1646–1648, 1662, 1681–1682, 1687, 1693, 1750, 1764, 1770, 1773, 1780, 1839, 1848, 1851, 1873–1875, 1880–1881, 1897–1898, 1902, 1915, 1919, 1925, 1927–1928, 1930–1931, 1933–1936, 1938, 1940, 1942–1945, 1947, 1950, 1952, 1956, 1959, 1961, 1965, 1968, 1970, 1974, 1977–1979, 1986, 1993, 1996–1997
TOTAL33302969270% 

Tests Skipped Failures Errors Time
2448 2 💤 0 ❌ 0 🔥 4m 2s ⏱️

@tyaroshko tyaroshko added the run-integration-tests-with-creds Trigger integration tests with credentials (optional) label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-integration-tests-with-creds Trigger integration tests with credentials (optional)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants