fix: disable sampling params for Claude 4.7+ models#781
Open
tyaroshko wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 92f9c07. Configure here.
| setattr(self, param, None) | ||
| elif self.__pydantic_extra__ is not None: | ||
| self.__pydantic_extra__.pop(param, None) | ||
| return recovered |
There was a problem hiding this comment.
Recovery mutates before retry succeeds
Medium Severity
_recover_completion_params clears sampling fields on the LLM instance before the retried _completion/_acompletion runs. If that retry still raises, the call fails but temperature, top_p, and related extras remain cleared on the reusable node.
Reviewed by Cursor Bugbot for commit 92f9c07. Configure here.
Coverage Report •
|
||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
Changes the shared LLM completion param path for all providers; behavior is limited to omitting sampling params and one retry, but workflows that relied on temperature on listed models will run with provider defaults instead.
Overview
Fixes 400 errors when calling newer Claude models (Opus 4.7+, Fable 5, Mythos, etc.) that reject
temperature,top_p, andtop_k.BaseLLM now strips those sampling params before the request when the model id matches
SAMPLING_UNSUPPORTED_MODEL_MARKERS, across Anthropic, Bedrock, and Custom LLM paths. If a model isn’t in the list yet,_recover_completion_paramsretries once without sampling when the error looks like “param not permitted/unsupported,” clears the values on the node for later calls, and leaves real validation failures (e.g. out-of-range temperature) unchanged.Adds unit tests for marker detection, proactive stripping, and reactive recovery.
Reviewed by Cursor Bugbot for commit 92f9c07. Bugbot is set up for automated code reviews on this repo. Configure here.