Fix biological warm start for cell ax bx#911
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #911 +/- ##
==========================================
+ Coverage 54.83% 54.96% +0.13%
==========================================
Files 321 322 +1
Lines 20568 20618 +50
==========================================
+ Hits 11278 11333 +55
+ Misses 9290 9285 -5 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description
Biological optimization warm-start handling does not consistently support
dij.axanddij.bxstored as cell arrays per CT scenario.This can affect initialization paths where
wInitis provided directly, becauseixDoseandgammawere computed assuming non-cell biological parameter arrays. The same biological metadata preparation was also partly duplicated acrossmatRad_fluenceOptimization.Approach
This PR adds
matRad_prepareBiologicalOptimizationDijto centralize biological dij preparation before initial fluence weights are estimated.The helper:
dij.axanddij.bxto one cell entry per CT scenarioax/bxvalues fromcstcstdij.ixDosedij.gammafor variable RBE projectionmatRad_fluenceOptimizationnow calls this helper once after selecting the back-projection model, so providedwInitand internally estimated warm starts use the same prepared biological metadata.No new user-facing parameters, external dependencies are introduced.
Validation
matRad_runTests('test/optimization/test_biologicalOptimizationDij.m')matRad_runTests('test/optimization')