Fix #29: avoid index out of range when --query-compute-apps returns m…#42
Open
deepujain wants to merge 1 commit intoeBay:masterfrom
Open
Fix #29: avoid index out of range when --query-compute-apps returns m…#42deepujain wants to merge 1 commit intoeBay:masterfrom
deepujain wants to merge 1 commit intoeBay:masterfrom
Conversation
…ns more rows than GPUs For --query-compute-apps, nvidia-smi returns one row per process (multiple processes can run on one GPU). The code assumed one row per GPU and allocated events[gpuCount], causing panic when processes > gpuCount. Use append so events slice grows with the actual number of rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29. When using --query-compute-apps, nvidia-smi returns one CSV row per process (not per GPU). If there are more processes than GPUs (e.g. several processes on one card), the beat panicked with index out of range [4] with length 4 because events were allocated as events[gpuCount] and indexed by row number. This change builds the events slice with append so the number of events matches the number of rows (one event per process).
Changes made
In run(), replaced fixed-size events := make([]common.MapStr, gpuCount, 2gpuCount) with events := make([]common.MapStr, 0, gpuCount2) and events = append(events, event) instead of events[gpuIndex] = event.
Request to eBay maintainer
Please review and merge when convenient. Thank you.