[Feature] Add xquery recursive collection creation with just one path expression #5062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizzzz
changed the title
adamretter
suggested changes
Sep 22, 2023
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
| } else { | ||
| try { | ||
| return new StringValue(this, collection.getName()); | ||
| } catch (XMLDBException e) { |
There was a problem hiding this comment.
exception should be marked final
| if (collectionNeedsClose && collection != null) { | ||
| try { | ||
| collection.close(); | ||
| } catch (final Exception e) { |
There was a problem hiding this comment.
Avoid catch-all Exception. Instead specify explicitly multiple exceptions separated by |
…eate-with-just-the-path
…' of github.com:enima007/exist into feature/add-xquery-collection-create-with-just-the-path
…eate-with-just-the-path
adamretter
suggested changes
Oct 15, 2023
| declare | ||
| %test:assertEquals("/db/parent-collection/path/to/new-collection") | ||
| function t:fnCreateNewRecursiveCollection() { | ||
| let $collection := xmldb:create-collection($t:path-collection) |
There was a problem hiding this comment.
Do I understand correctly that you are currently testing that:
xmldb:create-collection("/parent-collection/path/to/new-collection")
creates the collection /db/parent-collection/path/to/new-collection?
If so, that should not work! The xmldb:create-collection#1 function should always take an absolute path, i.e. starting with /db. This test should be modified to check for an error result, and the implementation updated accordingly.
adamretter
reviewed
Oct 15, 2023
adamretter
reviewed
Oct 15, 2023
adamretter
reviewed
Oct 15, 2023
adamretter
reviewed
Oct 15, 2023
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
adamretter
reviewed
Oct 15, 2023
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
adamretter
reviewed
Oct 15, 2023
exist-core/src/main/java/org/exist/xquery/functions/xmldb/XMLDBCreateCollection.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
dizzzz
reviewed
Nov 7, 2023
| } | ||
|
|
||
| try { | ||
| final Collection newCollection = createCollectionPath(collection, collectionName); |
There was a problem hiding this comment.
shoudl this go in to try(final Collection newCollection..) ?
line-o
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added an xmldb:create-collection#1 function to XMLDBModule.java and updated XMLDBCreateCollection.java implementation
to allow the creation of a new collection just by specifying its path.
Reference:
Closes #4238.
Type of tests:
Added a small assertEqual test in exist-core/src/test/xquery/xmldb/collection-create-tests.xql to check if
the collection is created successfully.