Modified AudioFileSource ID3 to enable tag skipping.

[troisiemetype]

Hello,

This follows the issue #349 opened sooner this day, about the random buffer silence / noise at the beginning of a mp3 play.

For what I understand, when reading a mp3, two things can happen :

• we want to read tags : an AudioFileSourceID3 object is created, which is called from AudioGeneratorMP3. It reads the tags, and simply relays the data from file when the job is done. Fine, when the tags have been read the music starts.
• we don't want to read tags : an AudioFileSourceXXX is created, but between the beginning of the file and the beginning of audio data (i.e. when in tag data), the AudioOutputXXX reads from a buffer which is not updated.

So, I've modified the AudioFileSourceID3 to add the following : a bool skip member variable, that can be changed in the constructor, and defaults to 0 : AudioFileSourceID3(AudioFileSource *src, bool skip = false);

This variable is tested once the tag header has been parsed, and its size is known. If true, the size of the tag section is skipped, and music can start immediately.

edit : I believe this is not the better way to solve this problem. By reading issue #347, it seems that the same behavior can happen with other file types as well.

[volkerjooss]

This changes solved my issue with noice at the beginning of the track.
I think it is mainly caused by to cover included in id3 tags.

[sittelle]

Any updates on this matter?