Skip to content

Commit

Permalink
ringhash: Remove TODO comment (grpc#8096)
Browse files Browse the repository at this point in the history
  • Loading branch information
arjan-bal authored Feb 19, 2025
1 parent ddb2484 commit 05bdd66
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions xds/internal/balancer/ringhash/ringhash.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,17 +231,6 @@ func (b *ringhashBalancer) updatePickerLocked() {
// TF. Since there must be at least one endpoint attempting to connect,
// we need to trigger one.
//
// TODO: https://github.com/grpc/grpc-go/issues/8085 - Restrict the
// condition under which an endpoint is connected. The pseudocode
// mentioned in A61 doesn't handle the following edge cases where the
// aggregated state is TF, but no endpoint actually enters TF:
// 1. There are four endpoints in the following states: TF, TF, READY,
// and IDLE. If the READY endpoint fails, it transitions to IDLE,
// resulting in the new states: TF, TF, IDLE, IDLE.
// 2. There are four endpoints in the following states: TF, TF,
// CONNECTING, and IDLE. If the CONNECTING endpoint is removed, the
// new states become: TF, TF, IDLE.

// After calling `ExitIdle` on a child balancer, the child will send a
// picker update asynchronously. A race condition may occur if another
// picker update from endpointsharding arrives before the child's
Expand Down

0 comments on commit 05bdd66

Please sign in to comment.