vet: add check to ensure terminating newline (grpc#7645)

easwars · Oct 7, 2024 · e8a70c6 · e8a70c6
1 parent 5fd9853
commit e8a70c6
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/Documentation/grpc-metadata.md b/Documentation/grpc-metadata.md
@@ -241,4 +241,4 @@ available [here](../examples/features/metadata_interceptor/server/main.go).
 [Header]: https://godoc.org/google.golang.org/grpc#Header
 [Trailer]: https://godoc.org/google.golang.org/grpc#Trailer
 [CallOption]: https://godoc.org/google.golang.org/grpc#CallOption
-[metadata]: https://godoc.org/google.golang.org/grpc/metadata
+[metadata]: https://godoc.org/google.golang.org/grpc/metadata
diff --git a/examples/data/rbac/policy.json b/examples/data/rbac/policy.json
@@ -27,4 +27,4 @@
     }
   ],
   "deny_rules": []
-}
+}
diff --git a/examples/features/name_resolving/README.md b/examples/features/name_resolving/README.md
@@ -38,4 +38,4 @@ proper name resolver, this would fail. In the example it picks the `example`
 resolver that we installed. The `example` resolver can handle
 `resolver.example.grpc.io` correctly by returning the backend address. So even
 though the backend IP is not set when ClientConn is created, the connection will
-be created to the correct backend.
+be created to the correct backend.
diff --git a/reflection/test/grpc_testing_not_regenerate/dynamic.proto b/reflection/test/grpc_testing_not_regenerate/dynamic.proto
@@ -30,4 +30,4 @@ message DynamicReq {}
 service DynamicService {
   // DynamicMessage1 is a test RPC for dynamically constructed protobufs.
   rpc DynamicMessage1(DynamicReq) returns (DynamicRes);
-}
+}
diff --git a/scripts/vet.sh b/scripts/vet.sh
@@ -70,6 +70,9 @@ not git grep "\(import \|^\s*\)\"google.golang.org/grpc/interop/grpc_testing" --
 # - Ensure that no trailing spaces are found.
 not git grep '[[:blank:]]$'
 
+# - Ensure that all files have a terminating newline.
+git ls-files | not xargs -I {} sh -c '[ -n "$(tail -c 1 "{}" 2>/dev/null)" ] && echo "{}: No terminating new line found"' | fail_on_output
+
 # - Ensure that no tabs are found in markdown files.
 not git grep $'\t' -- '*.md'
 

diff --git a/testdata/x509/client_with_spiffe_openssl.cnf b/testdata/x509/client_with_spiffe_openssl.cnf
@@ -14,4 +14,4 @@ extendedKeyUsage        = critical,clientAuth
 subjectAltName = @alt_names
 
 [alt_names]
-URI = spiffe://foo.bar.com/client/workload/1
+URI = spiffe://foo.bar.com/client/workload/1
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,4 +27,4 @@ @@
         }
       ],
       "deny_rules": []
-    }
+    }