Skip to content

check module_extensions value before generating extensions string #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

check module_extensions value before generating extensions string #4898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions easybuild/tools/module_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1312,13 +1312,14 @@ def get_description(self, conflict=True):
elif conflict:
# conflict on 'name' part of module name (excluding version part at the end)
lines.extend(['', 'conflict("%s")' % os.path.dirname(self.app.short_mod_name)])
extensions_list = self.app.make_extension_string(name_version_sep='/', ext_sep=',')
if extensions_list:
extensions_stmt = 'extensions("%s")' % extensions_list
# put this behind a Lmod version check as 'extensions' is only (well) supported since Lmod 8.2.8,
# see https://lmod.readthedocs.io/en/latest/330_extensions.html#module-extensions and
# https://github.com/TACC/Lmod/issues/428
lines.extend(['', self.conditional_statement(self.check_version("8", "2", "8"), extensions_stmt)])
if build_option('module_extensions'):
extensions_list = self.app.make_extension_string(name_version_sep='/', ext_sep=',')
if extensions_list:
extensions_stmt = 'extensions("%s")' % extensions_list
# put this behind a Lmod version check as 'extensions' is only (well) supported since Lmod 8.2.8,
# see https://lmod.readthedocs.io/en/latest/330_extensions.html#module-extensions and
# https://github.com/TACC/Lmod/issues/428
lines.extend(['', self.conditional_statement(self.check_version("8", "2", "8"), extensions_stmt)])

return '\n'.join(lines + [''])

Expand Down
Loading