Skip to content

Make command environment of shell commands more discoverable in the log #4999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Make command environment of shell commands more discoverable in the log #4999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6acf3
Make command environment of shell commands more discoverable in the log
Flamefire Sep 15, 2025
da8aa4e
Combine log messages for run_shell_cmd into 1
Flamefire Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions easybuild/tools/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,17 +454,20 @@ def to_cmd_str(cmd):
cmd_name = fileprefix_from_cmd(os.path.basename(cmd_str.split(' ')[0]))
tmpdir = tempfile.mkdtemp(dir=toptmpdir, prefix=f'{cmd_name}-')

_log.info(f'run_shell_cmd: command environment of "{cmd_str}" will be saved to {tmpdir}')

cmd_out_fp = os.path.join(tmpdir, 'out.txt')
_log.info(f'run_shell_cmd: Output of "{cmd_str}" will be logged to {cmd_out_fp}')
if split_stderr:
cmd_err_fp = os.path.join(tmpdir, 'err.txt')
_log.info(f'run_shell_cmd: Errors and warnings of "{cmd_str}" will be logged to {cmd_err_fp}')
else:
cmd_err_fp = None

cmd_sh = create_cmd_scripts(cmd_str, work_dir, env, tmpdir, cmd_out_fp, cmd_err_fp)

log_str = f'Command environment of\n\t"{cmd_str}"\nwill be saved to {cmd_sh}\n'
log_str += f'Output will be logged to {cmd_out_fp}'
if cmd_err_fp:
log_str += f'\nErrors and warnings will be logged to {cmd_err_fp}'
_log.info(f'run_shell_cmd: {log_str}')

else:
tmpdir, cmd_out_fp, cmd_err_fp, cmd_sh = None, None, None, None

Expand Down