Skip to content

Device definitions available as patch releases (#19) #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iwr-redmond
Copy link
Contributor

@iwr-redmond iwr-redmond commented Jun 26, 2025

  • Switches automatic version bump from minor to patch
  • Updated Readme file with compatible release operator sample

Resolves: #19

- Switches automatic version bump from minor to patch
- Updated Readme file with compatible release operator sample
@cmdr2
Copy link
Contributor

cmdr2 commented Jun 27, 2025

Thanks. I've given this a bit more thought, and how about this - I'll update the major version if there are breaking changes, and the minor version if there are simple code changes, and the patch version for device database changes.

So people can depend on the minor version if they want updated code changes (non-breaking) along with device updates. If they rely on the patch version, then they'll get device DB updates until the next set of non-breaking code changes.

Otherwise this will force me to make every non-breaking code change (or internal refactor) a patch update, which is semantically wrong. And the major version will be quite pointless then, since it'll never increment.

Curious to know your thoughts. Thanks

@iwr-redmond
Copy link
Contributor Author

Sounds fine. I'll update the Readme text.

@iwr-redmond
Copy link
Contributor Author

iwr-redmond commented Jun 27, 2025

Just to confirm, running pip install 'torchruntime~=1.18' will install version 1.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning Scheme Change
2 participants