fix: enforce AgentKit result and lifecycle invariants - #41
Merged
Merged
Conversation
ebarti
marked this pull request as ready for review
July 10, 2026 22:38
ebarti
added a commit
that referenced
this pull request
Jul 10, 2026
## What - require permission, sandbox, tool-filter, and spend-cap options to be explicit keyword parameters - fail closed when SDK callables are uninspectable, positional-only, or accept required options only through opaque **kwargs - preserve best-effort forwarding for non-required compatibility options - report failures against the correct public task field - align adapter fakes with the locked SDK signatures ## Why A callable that accepts **kwargs can silently discard an option while appearing compatible. That is unsafe for permission posture and budget caps. ## Root cause The shared option filter treated variadic and uninspectable signatures as proof that every required option would be honored. ## Checks - 275 passed, 12 skipped - 9 installed-SDK signature contract tests passed - ruff check src tests - mypy ## Stack - Base: #41 - Next: #43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The previous value-based merge logic silently ignored explicit inputs such as sdk_executions=1, failed typed results could retain an unchecked dict, and one close failure leaked later cached runtimes.
Root cause
AgentKit used ordinary default values as both API values and presence markers, copied failed result fields verbatim, and closed cached runtimes fail-fast.
Checks
Stack