This repository was archived by the owner on Aug 18, 2023. It is now read-only.
Example pipeline to ensure that a specific term is present at release… #7
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time When the release is run, this is run as part of qc
amnonkhen
suggested changes
Jun 24, 2022
src/ontology/Makefile
Outdated
| ensure_terms_%: % | ||
| $(ROBOT) query -i $< --query ../sparql/ensure-terms-$<.sparql ensure-terms-$<.txt && grep -q true ensure-terms-$<.txt | ||
|
|
||
| test: ensure_terms_hpo_slim.owl |
There was a problem hiding this comment.
There is already a test rule in line 35. Should they be merged?
There was a problem hiding this comment.
Not necessary in make: this is simply extending the respective make target test, so it i=ensures that the ensure_terms test is also run when when test is run. I changed this now to all to ensure that the test is run always run when a release is run!
There was a problem hiding this comment.
Oh, I see. Thanks for clarifying.
amnonkhen
approved these changes
Jun 24, 2022
src/ontology/Makefile
Outdated
| ensure_terms_%: % | ||
| $(ROBOT) query -i $< --query ../sparql/ensure-terms-$<.sparql ensure-terms-$<.txt && grep -q true ensure-terms-$<.txt | ||
|
|
||
| test: ensure_terms_hpo_slim.owl |
There was a problem hiding this comment.
Oh, I see. Thanks for clarifying.
|
Hi @matentzn |
amnonkhen
approved these changes
Jun 29, 2022
|
I was thinking as this is not urgent to wait till Zoe is back and have here merge it - maybe she wants it a bit different.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… time
When the release is run, this is run as part of qc