fix: use context managers for all SQLite database connections #633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
🎯 Rationale
Database connections were not using Python context managers, which can lead to connection leaks if exceptions occur before
conn.close()is called. This refactoring ensures all connections are properly closed automatically.📝 Summary of Changes
Refactored 24 SQLite database connections across 5 files to use Python context managers (
withstatement).🔧 Technical Details
Changed from manual
conn.close()calls to usingwith sqlite3.connect() as conn:pattern. This follows Python best practices (PEP 343) and ensures connections are automatically closed even when exceptions occur.✅ Testing
📋 Checklist