Skip to content
This repository was archived by the owner on Jul 21, 2021. It is now read-only.

Conversation

@khalifima
Copy link
Contributor

No description provided.

@HansUweRempler HansUweRempler added this to the 04.20 milestone Mar 13, 2020
endforeach(HEADER ${USER_CONF_FILES})
endif(NOT EXISTS ${ABS_APP_CONFIG_PATH})
endif(NOT APP_CONFIG_PATH)
endif(NOT APP_CONFIG _PATH)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endif(NOT APP_CONFIG _PATH)
endif(NOT APP_CONFIG_PATH)

typo, ...not dramatic, as the contents of endif(...) are ignored anyway :)

* Test case Tear Down
* No required separate Test Case Tear Down for this example.

##################################################################################################################################

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the intention is to have a horizontal separator, you could use --- instead. That would draw a nice horizontal line.

Suggested change
##################################################################################################################################
---

1. Invoke the Uart_receive API
2. Expected return value from the API: RETCODE_FAILURE

/* @todo: Expectation is a failure because no device is sending data to the DUT UART. Beaglebone has to be integrated for validating this test case */
Copy link

@ChiefGokhlayeh ChiefGokhlayeh Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doxygen doesn't work in markdown. It potentially messes up the renderer.

Suggested change
/* @todo: Expectation is a failure because no device is sending data to the DUT UART. Beaglebone has to be integrated for validating this test case */
TODO: Expectation is a failure because no device is sending data to the DUT UART. Beaglebone has to be integrated for validating this test case.

Comment on lines +18 to +50
* ```
* ______ _____ _ _ _____ _____ ___ ______________ _____________ __
* | _ \ _ | | \ | | _ |_ _| | \/ | _ | _ \_ _| ___\ \ / /
* | | | | | | | | \| | | | | | | | . . | | | | | | | | | | |_ \ V /
* | | | | | | | | . ` | | | | | | | |\/| | | | | | | | | | | _| \ /
* | |/ /\ \_/ / | |\ \ \_/ / | | | | | \ \_/ / |/ / _| |_| | | |
* |___/ \___/ \_| \_/\___/ \_/ \_| |_/\___/|___/ \___/\_| \_/
*
*
* _____ _ _ _____ _____ _ _ _____ ___ ______ ___________ _
* |_ _| | | |_ _/ ___| | | | || ___|/ _ \| _ \ ___| ___ \ |
* | | | |_| | | | \ `--. | |_| || |__ / /_\ \ | | | |__ | |_/ / |
* | | | _ | | | `--. \ | _ || __|| _ | | | | __|| /| |
* | | | | | |_| |_/\__/ / | | | || |___| | | | |/ /| |___| |\ \|_|
* \_/ \_| |_/\___/\____/ \_| |_/\____/\_| |_/___/ \____/\_| \_(_)
* ```
*
* This file is managed through cmake! The <headername>.h.in file acts as the
* template for generating the "real" header during cmakes' configure stage.
* This generated header will be placed in your CMAKE_CURRENT_BINARY_DIR and
* included during building.
*
* In the template we refer to cmake variables through ${XYZ} or @XYZ@ notation.
* Any such occurrence will be populated by cmake with the coresponding variable
* value.
*
* The intended way of modifying values in this header is:
* A) Through the <headername>.cmake file located either in either the boards'
* or the apps' config folder.
* B) Through command line options such as:
* `$ cmake --build <BUILD_DIR> -D <VAR>=<VAL>`
* Where <VAR> is the name of a cmake variable and <VAL> it's associated
* value.
Copy link

@ChiefGokhlayeh ChiefGokhlayeh Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the intended way anymore. We reverted back to doing configuration directly in the headers and then letting cmake copy and replace them as needed (see cmake/KisoLibsConfig.cmake).

1. Invoke the Uart_control API with the following parameters,

* BCDS_Uart1
* BCDS_UART_MODE_ASYNCHRONOUS | BCDS_UART_DATA_BITS_8 | BCDS_UART_PARITY_NONE | BCDS_UART_STOP_BITS_1
Copy link

@ChiefGokhlayeh ChiefGokhlayeh Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these refer to KISO_...? Is that even up to date anymore??

* Purpose
* Test the Peripheral SPI functionality
* Test participants which are involved
* Test participant :- BSE
Copy link

@ChiefGokhlayeh ChiefGokhlayeh Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's a "BSE"? ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants