dtr chart updation for auth provisioning#41
Merged
aaronzi merged 7 commits intoeclipse-basyx:mainfrom Nov 24, 2025
Merged
Conversation
arnoweiss
suggested changes
Nov 18, 2025
Contributor
arnoweiss
left a comment
arnoweiss
left a comment
There was a problem hiding this comment.
Found one issue, didn't test the rest
charts/basyx/dependency_charts/aas-digitaltwinregistry/values.yaml
Outdated
Show resolved
Hide resolved
Member
|
Is this PR ready? |
arnoweiss
approved these changes
Nov 18, 2025
Contributor
arnoweiss
left a comment
arnoweiss
left a comment
There was a problem hiding this comment.
No, I want at least a proper PR description for this.
Contributor
Author
|
Description is added, also the readme is updated. |
arnoweiss
approved these changes
Nov 21, 2025
Contributor
Author
|
@aaronzi This PR is now ready. Please review, and if everything appears satisfactory, we can proceed with the merge. |
aaronzi
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates configuration and chart files to improve consistency across the Digital Twin Registry modules and to support required RBAC rules.
Changes Included
Replaced application.yml with application.properties
Reformatted the configuration file to align with the conventions used in other Digital Twin Registry modules.
Added authentication parameters to extended properties
Ensures that auth-related configuration is properly exposed and can be consumed by dependent services.
Added ConfigMap for RBAC rules in the Digital Twin Registry Helm chart
Introduces a dedicated ConfigMap to store RBAC rule definitions, enabling cleaner separation of responsibilities and easier management.
Impact
These changes maintain consistency across modules, enhance configuration clarity, and ensure required RBAC resources are included during deployment.