Skip to content

feat: replace Bitnami Keycloak dependency with cloudpirates chart #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronzi merged 3 commits into from
Apr 14, 2026
Merged

feat: replace Bitnami Keycloak dependency with cloudpirates chart #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4651c8
feat: replace Bitnami Keycloak dependency with cloudpirates chart
arnoweiss Apr 14, 2026
3e26446
fix: skip helm repo add for OCI-based chart dependencies
arnoweiss Apr 14, 2026
201c345
fix: address Copilot review comments on keycloak technical user secret
arnoweiss Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- name: Add repositories
run: |
for dir in $(ls -d charts/*/); do
helm dependency list $dir 2> /dev/null | tail +2 | head -n -1 | awk '$3 !~ /^file:/ { print "helm repo add " $1 " " $3 }' | while read cmd; do $cmd; done
helm dependency list $dir 2> /dev/null | tail +2 | head -n -1 | awk '$3 !~ /^file:/ && $3 !~ /^oci:/ { print "helm repo add " $1 " " $3 }' | while read cmd; do $cmd; done
Copy link
Copy Markdown
Member

@aaronzi aaronzi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact of this change?

Copy link
Copy Markdown
Contributor Author

@arnoweiss arnoweiss Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline not crashing, see https://github.com/eclipse-basyx/charts/actions/runs/24389821173/job/71232645058. OCI-repos don't have to be helm add'ed

done

- name: Run chart-testing (install)
Expand Down
29 changes: 4 additions & 25 deletions charts/basyx/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ apiVersion: v2
name: aas-basyx-v2-full
description: Umbrella chart for the AAS Basyx v2 Environment
type: application
version: 2.1.13
version: 2.2.0
appVersion: 2.0.0-milestone-06

dependencies:
Expand Down Expand Up @@ -66,28 +66,7 @@ dependencies:
repository: https://charts.bitnami.com/bitnami
alias: mongodb
condition: mongodb.enabled
- repository: https://charts.bitnami.com/bitnami
name: keycloak
version: 24.4.11
- name: keycloak
version: "0.20.0"
repository: oci://registry-1.docker.io/cloudpirates
Comment on lines +69 to +71
Copy link
Copy Markdown
Member

@aaronzi aaronzi Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the recommended image to use? Is it maintained and are current vulnerabilities considered?

Copy link
Copy Markdown
Contributor Author

@arnoweiss arnoweiss Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart just wraps the image. The image the chart defaults to is the official postgres image [1]. Cloudpirates has been the go-to distribution in the Tractus-X context [2] since bitnami refusing to deliver free updates to their self-hosted images. So we're arguably way better off.

[1] image: docker.io/keycloak/keycloak:26.5.6@sha256:8d44614c7479
[2] https://eclipse-tractusx.github.io/docs/release/trg-5/trg-5-07/

condition: keycloak.enabled

# MongoDB has an issue with charts not sitting well in an umbrella chart.
# This is a bug with some common variables being defined externally.
# Check README.md or install.sh for commands to deploy this separately.
# - name: mongodb
# version: "14.5.0"
# repository: https://charts.bitnami.com/bitnami

# External images from open-source helm charts
# - name: mosquitto
# version: 2.4.1
# repository: https://storage.googleapis.com/t3n-helm-charts
# - name: kafka
# version: 22.1.3
# repository: https://charts.bitnami.com/bitnami
# - name: influxdb
# version: 5.6.1
# repository: https://charts.bitnami.com/bitnami
# - name: grafana
# version: "9.6.6"
# repository: https://charts.bitnami.com/bitnami
Loading
Loading