-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate codicons with webviews #136
Integrate codicons with webviews #136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems right. However, it doesn't fix the missing icon described in #71, i.e. the filter icon is still now show.
Also, should we do the same for the other webviews (e.g. opened traces) in this project?
Hi Bernd, I tested the code on my end, I have the filter icons displayed on the DATA_TREE view mentioned in #71. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works now when running it from the development environment using the launch configuration. However, after building the vsix (yarn vsce:package) and installing it in VsCode using install from vsix, then it doesn't work, i.e. the filter icon is not shown. I suspect that the packaging has to be adapted as well.
Looks like it is a known-issue with |
Turns out the support for yarn workspace is not quite there yet for |
83c784f
to
82a03db
Compare
This commit adds a reference to the codicons CSS file to enable codicons inside the TraceViewPanel of the vs-code trace extension. It follows the example provided in the vs-code webview sample [1]. [1] https://github.com/microsoft/vscode-extension-samples/tree/main/webview-codicons-sample Fixes eclipse-cdt-cloud#89. Signed-off-by: Hoang Thuan Pham <[email protected]>
82a03db
to
e28bb92
Compare
I used the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. I tested with VsCode and Theia and the icons are now visible.
This commit adds a reference to the codicons CSS file to enable codicons inside the TraceViewPanel of the vs-code trace extension. It follows the example provided in the vs-code webview sample.
Fixes #89.