-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: axios instance timeout #1319
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1319 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1319", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
+ Coverage 91.75% 91.79% +0.04%
==========================================
Files 501 501
Lines 45535 45535
Branches 3165 3182 +17
==========================================
+ Hits 41781 41801 +20
+ Misses 3723 3702 -21
- Partials 31 32 +1 ☔ View full report in Codecov by Sentry. |
Can we make it configurable ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's configure it via env var |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@olexii4 @dmytro-ndp @olexii4 folks, I'm ok with this solution for now until we fine smth. better |
Build 3.20 :: dashboard_3.x/630: Console, Changes, Git Data |
Build 3.20 :: sync-to-downstream_3.x/8828: Console, Changes, Git Data |
cherry-pick PR #1322 |
Build 3.20 :: push-latest-container-to-quay_3.x/5096: Console, Changes, Git Data |
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8946: dashboard : 3.x :: Build 66771626 : quay.io/devspaces/dashboard-rhel9:3.20-3 |
Build 3.20 :: update-digests_3.x/8638: Console, Changes, Git Data |
Build 3.20 :: dashboard_3.x/630: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8828 triggered |
What does this PR do?
Increase axios instance timeout to 30 seconds:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23354
Is it tested? How?
Release Notes
Docs PR