Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: axios instance timeout #1319

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: axios instance timeout #1319

merged 1 commit into from
Feb 20, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Feb 19, 2025

What does this PR do?

Increase axios instance timeout to 30 seconds:

    this.axiosInstance = axios.create({ timeout: 30000 });

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23354

Is it tested? How?

Release Notes

Docs PR

Signed-off-by: Oleksii Orel <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Feb 19, 2025

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1319

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1319", name: che-dashboard}]}}]"

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.79%. Comparing base (4015e95) to head (199d092).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
+ Coverage   91.75%   91.79%   +0.04%     
==========================================
  Files         501      501              
  Lines       45535    45535              
  Branches     3165     3182      +17     
==========================================
+ Hits        41781    41801      +20     
+ Misses       3723     3702      -21     
- Partials       31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vinokurig
Copy link
Contributor

@olexii4
Should we increase the workspace creation timeout as well?

const timeoutError = new Error(
`Workspace hasn't been created in the last ${TIMEOUT_TO_CREATE_SEC} seconds.`,
);

@tolusha
Copy link
Contributor

tolusha commented Feb 19, 2025

Can we make it configurable ?

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 thanks for the follow up, but I'm wondering if we can expose this property on CR level e.g.

   dashboard:
      requestTimeout: 15

cc: @tolusha

@tolusha
Copy link
Contributor

tolusha commented Feb 19, 2025

let's configure it via env var
CHE_DASHBOARD_CHE_API_AXIOX_REQUEST_TIMEOUT

Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member

ibuziuk commented Feb 20, 2025

@olexii4 @dmytro-ndp @olexii4 folks, I'm ok with this solution for now until we fine smth. better
please, merge in main and back port to to 7.98.x for 3.19

@ibuziuk ibuziuk merged commit 1ad46ec into main Feb 20, 2025
21 checks passed
@ibuziuk ibuziuk deleted the CHE-23354 branch February 20, 2025 16:24
@devspacesbuild
Copy link

Build 3.20 :: dashboard_3.x/630: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@ibuziuk
Copy link
Member

ibuziuk commented Feb 20, 2025

cherry-pick PR #1322

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: dashboard_3.x/630: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8828 triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants