-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix case of kubectl create secret tls #2865
base: main
Are you sure you want to change the base?
Conversation
⚡️ Deploying pull request preview... |
if this fix is for any version of Che, it would be better to merge it into |
TLS does not work.
Oh, sorry- I created the PR with the "edit this page" link and I didn't notice where it landed. Fixed. |
no worries! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@alexveecle it seems you'll need to validate your mail + agree with terms & conditions of the eclipse foundation |
Yeah, I saw the ECA failing check. Cannot I just waive all rights over this PR? I'll go create an Eclipse account... |
Done |
What does this pull request change?
kubectl create secret TLS
does not work, must be case-sensitive.What issues does this pull request fix or reference?
None.
Specify the version of the product this pull request applies to
Any.
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.