Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix case of kubectl create secret tls #2865

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexveecle
Copy link

What does this pull request change?

kubectl create secret TLS does not work, must be case-sensitive.

What issues does this pull request fix or reference?

None.

Specify the version of the product this pull request applies to

Any.

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@alexveecle alexveecle requested review from deerskindoll and a team as code owners February 14, 2025 11:27
@alexveecle alexveecle requested review from ibuziuk and removed request for a team February 14, 2025 11:27
Copy link

github-actions bot commented Feb 14, 2025

⚡️ Deploying pull request preview...

Copy link

github-actions bot commented Feb 14, 2025

Click here to review and test in web IDE: Contribute

@deerskindoll
Copy link
Contributor

if this fix is for any version of Che, it would be better to merge it into main branch instead of 7.98 release branch

@alexveecle alexveecle changed the base branch from 7.98.x to main February 14, 2025 13:13
@alexveecle
Copy link
Author

Oh, sorry- I created the PR with the "edit this page" link and I didn't notice where it landed. Fixed.

@deerskindoll
Copy link
Contributor

no worries!

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deerskindoll
Copy link
Contributor

@alexveecle it seems you'll need to validate your mail + agree with terms & conditions of the eclipse foundation

@alexveecle
Copy link
Author

Yeah, I saw the ECA failing check. Cannot I just waive all rights over this PR?

I'll go create an Eclipse account...

@alexveecle
Copy link
Author

@alexveecle it seems you'll need to validate your mail + agree with terms & conditions of the eclipse foundation

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants