fixup! Throw an error if Devfile from unsupported ssh repository is n…

…ot resolved
eclipse-che · Feb 18, 2025 · 319c595 · 319c595
1 parent 7b5be5f
commit 319c595
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...i-factory-git-ssh/src/main/java/org/eclipse/che/api/factory/server/git/ssh/GitSshUrl.java b/...i-factory-git-ssh/src/main/java/org/eclipse/che/api/factory/server/git/ssh/GitSshUrl.java
@@ -73,7 +73,8 @@ public Optional<String> filename() {
 
       @Override
       public String location() {
-        return String.format("https://%s/%s/%s", hostName, repository, devfileFilename);
+        // TODO: throw exception. We do not know the location of the devfile.
+        return devfileFilename;
       }
     };
   }

diff --git a/...ctory-git-ssh/src/test/java/org/eclipse/che/api/factory/server/git/ssh/GitSshUrlTest.java b/...ctory-git-ssh/src/test/java/org/eclipse/che/api/factory/server/git/ssh/GitSshUrlTest.java
@@ -33,7 +33,7 @@ public void shouldReturnDevfileLocations() throws Exception {
             .withDevfileFilenames(Arrays.asList(devfileNames));
     List<DevfileLocation> devfileLocations = sshUrl.devfileFileLocations();
     assertEquals(devfileLocations.size(), 2);
-    assertEquals(devfileLocations.get(0).location(), "https://hostname/repository/devfile.yaml");
-    assertEquals(devfileLocations.get(1).location(), "https://hostname/repository/.devfile.yaml");
+    assertEquals(devfileLocations.get(0).location(), "devfile.yaml");
+    assertEquals(devfileLocations.get(1).location(), ".devfile.yaml");
   }
 }