fix: invalid array string types#209
Closed
perher wants to merge 1 commit intoeclipse-dataspace-protocol-base:mainfrom
Closed
fix: invalid array string types#209perher wants to merge 1 commit intoeclipse-dataspace-protocol-base:mainfrom
perher wants to merge 1 commit intoeclipse-dataspace-protocol-base:mainfrom
Conversation
Author
|
this was included in #211 |
Contributor
|
Thanks @perher for spotting this and also proposing a solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Fixes array schema definitions where
stringis used instead of a proper JSON schema typeWhy it does that
To be valid according to the 2019-09 JSON schema specification
Further notes
Identified two files where this pattern was used and updated those.
Linked Issue(s)
Closes #208
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.