Skip to content

Add current and new plugin versions while update#1001

Merged
merks merged 1 commit intoeclipse-equinox:masterfrom
subyssurendran666:current_and_update_plugin_version_935
May 2, 2026
Merged

Add current and new plugin versions while update#1001
merks merged 1 commit intoeclipse-equinox:masterfrom
subyssurendran666:current_and_update_plugin_version_935

Conversation

@subyssurendran666
Copy link
Copy Markdown
Contributor

@subyssurendran666 subyssurendran666 commented Feb 13, 2026

This change enhances the update wizard to display both the currently installed version and the available update version for each feature. This allows users to easily compare versions and make more informed decisions when selecting updates.
image

Fix: #935

@iloveeclipse
Copy link
Copy Markdown
Member

Screenshot?

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

There are two areas where changes were required for this fix. I have added a unit test for IUDetailsLabelProvider, but I’m unsure how to write a unit test for ResolutionResultsWizardPage. I also reviewed the revision history of the modified area, and it appears that no unit tests were added there previously. Could someone please guide me on how to approach testing this part?

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

image

I also have a concern regarding the UX aspect of this approach. If both version IDs are too long, it could significantly affect readability. I considered displaying the new version in a separate column, but that may not be ideal from a UX perspective either

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 13, 2026

Test Results

   18 files  ±0     18 suites  ±0   29m 12s ⏱️ -7s
1 902 tests ±0  1 899 ✅ ±0  3 💤 ±0  0 ❌ ±0 
5 161 runs  ±0  5 152 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 8dc2578. ± Comparison against base commit 49759ef.

♻️ This comment has been updated with latest results.

@laeubi
Copy link
Copy Markdown
Member

laeubi commented Feb 13, 2026

I would say display both versions in two colums (From, To)

If you are concerned about the length I think one can shorten the version for display, e.g. only Major.Minor.Micro the qualifier is almost useless in all cases.

I think a good algorithm would be to find the first differing segment and reduce it to that e.g. lets say the Major version is different then just show Major version, if minor is different show major+minor and so on... that's the actual relevant information and the full version details can be shown when hovering in a tooltip or elsewhere.

@merks
Copy link
Copy Markdown
Contributor

merks commented Feb 13, 2026

One useful bit of information in the qualifier is the date which is typically the only information that's meaningful to the user who is generally not familiar with the versioning scheme of the unit. I agree though that it looks a bit like "too much information" and that two columns would allow one to squeeze down the column to truncation the qualifier. (I wonder, are the columns packed or is a column layout used.)

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

subyssurendran666 commented Feb 13, 2026

Thanks for the feedbacks, I will come up with a two columns approach.

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

image image

I have reimplemented the UI with Installed Version and Available Version columns. However, I still do not have much idea about how to write the tests for this scenario. I would appreciate it if someone could guide me on how to write a unit test for this.

@subyssurendran666
Copy link
Copy Markdown
Contributor Author

@merks could you please review this PR ?

@subyssurendran666 subyssurendran666 force-pushed the current_and_update_plugin_version_935 branch from 7aa8f37 to a709cae Compare March 16, 2026 15:21
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

@laeubi Could you please trigger the GitHub Copilot review for this PR?

@subyssurendran666 subyssurendran666 force-pushed the current_and_update_plugin_version_935 branch from a709cae to 938e3ff Compare April 29, 2026 16:25
@subyssurendran666 subyssurendran666 requested a review from merks April 29, 2026 16:30
@merks
Copy link
Copy Markdown
Contributor

merks commented Apr 29, 2026

Generally it looks good, but I’m on my phone. Are the screen shots up to date? Probably you will want to write an N&N entry with nice screenshots…

@subyssurendran666 subyssurendran666 force-pushed the current_and_update_plugin_version_935 branch from 938e3ff to c7c716b Compare April 30, 2026 04:49
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

Generally it looks good, but I’m on my phone. Are the screen shots up to date? Probably you will want to write an N&N entry with nice screenshots…

Here are the latest screenshots.

image image

@merks
Copy link
Copy Markdown
Contributor

merks commented May 1, 2026

@subyssurendran666

Sorry, I message up trying to do a rebase but instead did a merge commit. Sorry sorry. Could you please force push a rebased commit?

This change enhances the update wizard to display both the currently
installed version and the available update version for each feature.
This allows users to easily compare versions and make more informed
decisions when selecting updates.

Fix: eclipse-equinox#935
@subyssurendran666 subyssurendran666 force-pushed the current_and_update_plugin_version_935 branch from 6c834c1 to 8dc2578 Compare May 2, 2026 02:39
@subyssurendran666
Copy link
Copy Markdown
Contributor Author

@subyssurendran666

Sorry, I message up trying to do a rebase but instead did a merge commit. Sorry sorry. Could you please force push a rebased commit?

Done.

@merks merks merged commit 308fa50 into eclipse-equinox:master May 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display the currently installed version of a feature in the update wizard

4 participants