Skip to content

Don't call pack() on not yet visible table on Linux #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iloveeclipse wants to merge 2 commits into from
Closed

Don't call pack() on not yet visible table on Linux #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8244d2e
Don't call pack() on not yet visible table on Linux
iloveeclipse Sep 17, 2025
ab49549
Version bump(s) for 4.38 stream
eclipse-equinox-bot Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bundles/org.eclipse.equinox.p2.ui.sdk/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %bundleName
Bundle-SymbolicName: org.eclipse.equinox.p2.ui.sdk;singleton:=true
Bundle-Version: 1.3.500.qualifier
Bundle-Version: 1.3.600.qualifier
Bundle-Activator: org.eclipse.equinox.internal.p2.ui.sdk.ProvSDKUIActivator
Bundle-Vendor: %providerName
Bundle-Localization: plugin
Expand Down
13 changes: 12 additions & 1 deletion ...pse.equinox.p2.ui.sdk/src/org/eclipse/equinox/internal/p2/ui/sdk/TrustPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.eclipse.jface.preference.PreferencePage;
import org.eclipse.jface.resource.JFaceResources;
import org.eclipse.jface.util.Policy;
import org.eclipse.jface.util.Util;
import org.eclipse.jface.viewers.*;
import org.eclipse.jface.widgets.WidgetFactory;
import org.eclipse.jface.window.Window;
Expand Down Expand Up @@ -417,7 +418,17 @@ public Image getImage() {

certificateViewer.addDoubleClickListener(e -> details.run());

typeColumn.getColumn().pack();
if (Util.isLinux()) {
// pack() produces stack overflow on not yet visible table
Control control = certificateViewer.getControl();
control.getDisplay().asyncExec(() -> {
if (!control.isDisposed()) {
typeColumn.getColumn().pack();
}
});
} else {
typeColumn.getColumn().pack();
}

var menu = new Menu(table);
table.setMenu(menu);
Expand Down
Loading