Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSP-1369 Fix wrong edge type hint #93

Merged
merged 1 commit into from
Jul 15, 2024
Merged

GLSP-1369 Fix wrong edge type hint #93

merged 1 commit into from
Jul 15, 2024

Conversation

tortmayr
Copy link
Contributor

Part of eclipse-glsp/glsp#1369

What it does

  • Ensure that the type hint for weighted edges if created with the correct elementTypeId

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr
GLSP-1369 Fix wrong edge type hint
6d7799e 
- Ensure that the type hint for weighted edges if created with the correct `elementTypeId`

Part of eclipse-glsp/glsp#1369
planger
planger approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit 951ddf1 into main Jul 15, 2024
5 of 6 checks passed
@tortmayr tortmayr deleted the glsp/1369 branch July 15, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @planger