Skip to content

Problem with calling super in overridden default method #4776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephan-herrmann wants to merge 1 commit into
base: master
Choose a base branch
from
+39 −4
Open

Problem with calling super in overridden default method #4776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/Scope.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4681,10 +4681,10 @@ protected final MethodBinding mostSpecificMethodBinding(MethodBinding[] visible,
receiverType = receiverType instanceof CaptureBinding ? receiverType : (ReferenceBinding) receiverType.erasure();

// within the boundaries of "chosen arbitrarily among the subset of the maximally specific methods that are preferred"
// put concrete methods first, default methods second:
// put implemented methods first:
Arrays.sort(moreSpecific, (m1, m2) -> {
int rank1 = m1 == null ? 3 : m1.isAbstract() ? 2 : m1.isDefaultMethod() ? 1 : 0;
int rank2 = m2 == null ? 3 : m2.isAbstract() ? 2 : m2.isDefaultMethod() ? 1 : 0;
int rank1 = m1 == null ? 3 : m1.isAbstract() ? 2 : 0;
int rank2 = m2 == null ? 3 : m2.isAbstract() ? 2 : 0;
return rank1 - rank2;
});
boolean hasConsideredNullContract = false;
Expand All @@ -4703,7 +4703,7 @@ protected final MethodBinding mostSpecificMethodBinding(MethodBinding[] visible,
if (TypeBinding.equalsEquals(original.declaringClass, original2.declaringClass))
break nextSpecific; // duplicates thru substitution

if (!original.isAbstract()) {
if (!original.isAbstract() && !original.isDefaultMethod()) {
if (original2.isAbstract() || original2.isDefaultMethod())
continue; // only compare current against other concrete methods

Expand Down
35 changes: 35 additions & 0 deletions ...sts.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/InterfaceMethodsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3312,4 +3312,39 @@ default void setReadOnly(boolean readOnly) {
}
"""});
}
public void testGH1600_2() {
runConformTest(new String[] {"Test.java",
"""
interface I0 {
default void m() throws Exception {}
default Number n() throws Exception { return 0l; }
}
interface I2 extends I0 {
@Override abstract void m() throws Exception;
@Override abstract Integer n() throws Exception;
}
class C2 implements I2 {
@Override public Integer n() throws Exception { return 13; }
@Override public void m() {}
}
public class Test {
void test1(I0 i) throws Exception {
if (i instanceof I2)
((I2) i).m();
else
System.out.print("no");
}
void test2(I0 i0) throws Exception {
Integer i = ((I2) i0).n();
System.out.print(i);
}
public static void main(String... args) throws Exception {
Test t = new Test();
t.test1(new I0() {});
t.test2(new C2());
}
}
"""},
"no13");
}
}
Loading