Skip to content

Print warning if adding parent folder of library to the classpath #4797 #4817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fedejeanne wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Print warning if adding parent folder of library to the classpath #4797 #4817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/ClasspathEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,6 +986,14 @@ private static void resolvedChainedLibraries(IPath jarPath, HashSet visited, Arr
}
continue;
}
if (JavaModelManager.CP_RESOLVE_VERBOSE_FAILURE && calledJar.isPrefixOf(jarPath)) {
// Adding parent folders is a hack that some JARs use to spare some effort,
// but it may cause issues like having invalid duplicated classes in the classpath.
// See https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4797
trace("WARN: Classpath entry " + calledFileName + " in manifest of jar file: " //$NON-NLS-1$ //$NON-NLS-2$
+ jarPath.toOSString()
+ " references a parent folder. This may cause issues like duplicated classes in the classpath, wrong hierarchies, etc. For more details, see https://github.com/eclipse-jdt/eclipse.jdt.core/issues/4797."); //$NON-NLS-1$
}
resolvedChainedLibraries(calledJar, visited, result);
result.add(calledJar);
}
Expand Down
Loading