Skip to content

Cache PackageFragment.getElementName() to avoid repeated String creation #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laeubi wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

Cache PackageFragment.getElementName() to avoid repeated String creation #4934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/PackageFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ public class PackageFragment extends Openable implements IPackageFragment, Suffi

private final boolean isValidPackageName;

private volatile String cachedElementName;

protected PackageFragment(PackageFragmentRoot root, String[] names) {
super(root);
this.names = names;
Expand Down Expand Up @@ -322,7 +324,12 @@ public ICompilationUnit[] getCompilationUnits(WorkingCopyOwner owner) {
public String getElementName() {
if (this.names.length == 0)
return DEFAULT_PACKAGE_NAME;
return Util.concatWith(this.names, '.');
String name = this.cachedElementName;
if (name == null) {
name = Util.concatWith(this.names, '.');
this.cachedElementName = name;
}
return name;
}
/**
* @see IJavaElement
Expand Down
Loading