[Markdown] Snippet tag failed to generate javadoc#5003
Conversation
8ce645f to
adc3441
Compare
There was a problem hiding this comment.
Pull request overview
Fixes Markdown doc comment parsing so {@snippet ...} content (especially plain inlined snippet text) is extracted and can be rendered in the Javadoc view (Issue #4968).
Changes:
- Update the compiler’s comment parser to capture Markdown snippet text and adjust snippet validity handling.
- Add Markdown-focused regression tests for
@snippettags.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterMarkdownTest.java | Adds new Markdown snippet parsing tests. |
| org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java | Adjusts snippet parsing to capture Markdown snippet content and set snippet validity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c239168 to
b2c5808
Compare
b2c5808 to
66b4411
Compare
|
@subyssurendran666 Are you planning to address the review comments raised by CoPilot? Please disable it otherwise. There's just too much information here. |
66b4411 to
e172b4b
Compare
I have addressed the problems addressed by the co-pilot and added necessary comments. |
e172b4b to
ee31b69
Compare
The @snippet tag content was not being rendered in the Javadoc view because plain snippet text was not captured during parsing. This change ensures snippet content is properly extracted and displayed, similar to standard Javadoc elements. Fix: eclipse-jdt#4968
ee31b69 to
59b2847
Compare
The @snippet tag content was not being rendered in the Javadoc view because plain snippet text was not captured during parsing. This change ensures snippet content is properly extracted and displayed, similar to standard Javadoc elements.
Fix: #4968
What it does
How to test
Scenario
Author checklist