Migrate from SubProgressMonitor to SubMonitor#2641
Draft
vogella wants to merge 1 commit into
Draft
Conversation
vogella
force-pushed
the
claude/migrate-subprogressmonitor-submonitor-01JxrbTufgL8ZLDKSx9tS6hL
branch
2 times, most recently
from
25f7c6c to
5161d45
Compare
vogella
force-pushed
the
claude/migrate-subprogressmonitor-submonitor-01JxrbTufgL8ZLDKSx9tS6hL
branch
from
5161d45 to
7906c72
Compare
jjohnstn
force-pushed
the
claude/migrate-subprogressmonitor-submonitor-01JxrbTufgL8ZLDKSx9tS6hL
branch
from
7906c72 to
c0af4de
Compare
This commit migrates the codebase from the deprecated SubProgressMonitor (deprecated since Eclipse 4.6 Neon) to SubMonitor as per Eclipse API recommendations. Changes: - Updated Progress.java utility class to use SubMonitor.convert() and split() methods instead of SubProgressMonitor - Migrated EditorUtility.java to use SubMonitor pattern directly, removing the getSubProgressMonitor method and unused imports - Migrated CompilationUnitDocumentProvider.java to use SubMonitor pattern in commitWorkingCopy and notifyPostSaveListeners methods - Removed calls to monitor.done() and subMonitor.done() where not needed (SubMonitor handles cleanup automatically in most cases) - Updated PREPEND_MAIN_LABEL_TO_SUBTASK usage to use plain split() as there is no direct replacement; clients should use fully- formatted task labels instead The migration follows the official Eclipse migration guide: - Replaced IProgressMonitor.beginTask() with SubMonitor.convert() - Replaced new SubProgressMonitor(monitor, ticks) with split(ticks) - Replaced SUPPRESS_SUBTASK_LABEL flag with SubMonitor.SUPPRESS_SUBTASK
vogella
force-pushed
the
claude/migrate-subprogressmonitor-submonitor-01JxrbTufgL8ZLDKSx9tS6hL
branch
from
c0af4de to
6846852
Compare
Contributor
Author
|
I will split the changes in org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/wizards/NewTypeWizardPage.java out of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit migrates the codebase from the deprecated SubProgressMonitor (deprecated since Eclipse 4.6 Neon) to SubMonitor as per Eclipse API recommendations.
Changes:
The migration follows the official Eclipse migration guide:
What it does
How to test
Author checklist