Use ILog API for logging in org.eclipse.jdt.junit.core#2987
Open
vogella wants to merge 1 commit into
Open
Conversation
Replace JavaPlugin/JUnitCorePlugin.log() wrapper calls with direct ILog usage. Files with multiple call sites get a static ILog.of(MyClass.class) field; single-call sites use ILog.of(MyClass.class) inline. Also removes the now-unused log() helper methods from JUnitCorePlugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the JUnitCorePlugin.log() wrapper methods with direct use of the Eclipse ILog API. Files with multiple logging call sites get a private static final ILog field via ILog.of(MyClass.class); single-call sites use ILog.of(MyClass.class) inline. This removes the indirection through the plugin activator and stamps each log entry with the bundle that actually owns the code, rather than always attributing it to the UI plugin.