Migrate NewTypeWizardPage.createType() from SubProgressMonitor to SubMonitor#2988
Open
vogella wants to merge 1 commit into
Open
Migrate NewTypeWizardPage.createType() from SubProgressMonitor to SubMonitor#2988vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
…Monitor Replace the deprecated SubProgressMonitor pattern (beginTask + worked) with a single SubMonitor.convert() at the method entry followed by split() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the deprecated
SubProgressMonitorpattern increateType()with the modernSubMonitorAPI. The method previously calledmonitor.beginTask()once and then passed the same raw monitor repeatedly toProgress.subMonitor(), which internally createsSubProgressMonitorinstances. The new code callsSubMonitor.convert()once at the entry point and usessplit()for each unit of work, including the previously baremonitor.worked(1)calls. The unusedProgressimport is also removed.