Skip to content

Commit

Permalink
Implement further review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kaisalmen committed Jul 1, 2024
1 parent 94d47f6 commit b6b78f7
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 3 additions & 1 deletion packages/generator-langium/templates/gitignore.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
!.vscode/launch.json
!.vscode/tasks.json
node_modules/
dist/
out/
src/generated/
**/src/generated
syntaxes/
*.tsbuildinfo
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { afterEach, beforeAll, describe, expect, test } from "vitest";
import { EmptyFileSystem, type LangiumDocument } from "langium";
import { expandToString as s } from "langium/generate";
import { clearDocuments, parseHelper } from "langium/test";
import { create<%= LanguageName %>Services, isModel, Model } from "<%= language-id %>-language";
import type { Model } from "<%= language-id %>-language";
import { create<%= LanguageName %>Services, isModel } from "<%= language-id %>-language";

let services: ReturnType<typeof create<%= LanguageName %>Services>;
let parse: ReturnType<typeof parseHelper<Model>>;
Expand Down Expand Up @@ -47,6 +48,6 @@ function checkDocumentValid(document: LangiumDocument): string | undefined {
${document.parseResult.parserErrors.map(e => e.message).join('\n ')}
`
|| document.parseResult.value === undefined && `ParseResult is 'undefined'.`
|| !isModel(document.parseResult.value) && `Root AST object is a ${document.parseResult.value.$type}, expected a '${Model}'.`
|| !isModel(document.parseResult.value) && `Root AST object is a ${document.parseResult.value.$type}, expected a 'Model'.`
|| undefined;
}
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,6 @@ function checkDocumentValid(document: LangiumDocument): string | undefined {
${document.parseResult.parserErrors.map(e => e.message).join('\n ')}
`
|| document.parseResult.value === undefined && `ParseResult is 'undefined'.`
|| !isModel(document.parseResult.value) && `Root AST object is a ${document.parseResult.value.$type}, expected a Model'.`
|| !isModel(document.parseResult.value) && `Root AST object is a ${document.parseResult.value.$type}, expected a 'Model'.`
|| undefined;
}

0 comments on commit b6b78f7

Please sign in to comment.