Skip to content

Conversation

sailingKieler
Copy link
Contributor

  • added additional test cases

… platform regarding drive letter cases

* added additional test cases
@sailingKieler sailingKieler added this to the v3.4.0 milestone Feb 21, 2025
@sailingKieler sailingKieler requested a review from msujew February 21, 2025 11:08
@msujew msujew changed the title langium: another refinement in 'uri-utils.ts' specific to the Windows platform regarding drive letter cases Improve Windows drive letter URI handling Feb 21, 2025
@sailingKieler sailingKieler force-pushed the cs/uriUtilsDriveLetters branch 2 times, most recently from 0422556 to 189a937 Compare February 21, 2025 14:52
@sailingKieler
Copy link
Contributor Author

Some tests with string input to UriUtils.relativize(...) should be added.
But today it's enough for me.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good to me 👍

@msujew msujew merged commit 0e058c7 into main Feb 26, 2025
5 checks passed
@msujew msujew deleted the cs/uriUtilsDriveLetters branch February 26, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants