-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Handle XMLLiteral Java type #214
base: master
Are you sure you want to change the base?
Conversation
We did a screenshare review with Jad. The question is if we want to include it in Lyo 4.1 release. I would suggest to keep it for 4.2/5.0. |
I also vote to wait. Then we can use and test it a bit more |
SonarCloud Quality Gate failed. |
360e1b8
to
cb41849
Compare
SonarCloud Quality Gate failed. |
3ba8840
to
74a94b7
Compare
899ef98
to
46c1f5c
Compare
6a0b161
to
fd9b6b8
Compare
fd9b6b8
to
1ac77ea
Compare
857a0f8
to
d82b6df
Compare
d82b6df
to
018e75d
Compare
From the run output:
I believe the errors were introduced not due to changes on |
0c15b1c
to
d3e8077
Compare
d3e8077
to
5d6f8b0
Compare
e4ce358
to
5366b17
Compare
5366b17
to
1404355
Compare
1404355
to
02135e2
Compare
02135e2
to
a6c5736
Compare
a6c5736
to
3efd378
Compare
…atatype. Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
Signed-off-by: Andrew Berezovskyi <[email protected]>
3efd378
to
c9d0e55
Compare
@jadelkhoury do you know how to fix the latest build errors? It looks related to the Jakarta migration. |
Description
Lyo uses
XMLLiteral
type for XML Literals in RDF when creating extended properties but uses String type for annotated Java properties for the same RDF type. This caused differences in processing of the same content depending on the property name. See https://forum.open-services.net/t/oslc4j-cannot-get-a-changerequest-that-contains-special-characters/492/11This PR allows you to use XMLLiteral both as an OSLC ValueType and as a Java property type:
This may result in more strict handling of the property value. No existing behaviour is expected to change. See #213 for a helper to check if a String contains valid XML.
Checklist