Skip to content

Fix for PWM on Beaglebone black with a kernel > 3.8.13#273

Open
SyrianSpock wants to merge 1 commit intoeclipse-mraa:masterfrom
SyrianSpock:master
Open

Fix for PWM on Beaglebone black with a kernel > 3.8.13#273
SyrianSpock wants to merge 1 commit intoeclipse-mraa:masterfrom
SyrianSpock:master

Conversation

@SyrianSpock
Copy link
Copy Markdown
Contributor

Tested on hardware (Beaglebone black Rev B6)

Signed-off-by: Salah-Eddine Missri <missrisalaheddine@gmail.com>
@arfoll
Copy link
Copy Markdown
Contributor

arfoll commented Sep 7, 2015

Thanks for the contribution! Is this a debian thing or global? I've never seen such a thing and edison for example has a 3.10 kernel? I'd like to understand if this is a beaglebone thing or general? Quark also uses a 3.8.x kernel and doesn't have this.

@SyrianSpock
Copy link
Copy Markdown
Contributor Author

I have only seen this on the Beaglebone black with Debian and Ubuntu.
I don't know if the Beaglebone is the only board concerned or if it's an Linux on ARM thingy, sorry I don't have an answer.

@arfoll
Copy link
Copy Markdown
Contributor

arfoll commented Sep 8, 2015

Ok I unfortunately don't have a BBB, @tingleby do you think you could take a look? My only arm platform is an rpi2 and that doesn't have pwm (least not natively)

@arfoll
Copy link
Copy Markdown
Contributor

arfoll commented Sep 8, 2015

@cosscat is this something you could help with if you have a board?

@alext-mkrs
Copy link
Copy Markdown
Contributor

I don't have BBB either, but I've found this nice description: https://github.com/szmoore/MCTX3420/wiki/Software:-PWM-Control and looks like the standard sysfs location is actually just a secondary mean to use PWMs on BBB and the one that doesn't follow the kernel documentation fully (dropping the pwmchip piece).

@alext-mkrs
Copy link
Copy Markdown
Contributor

I believe this should rather be reworked using _replace approach, as this is specific to one board we support. @SyrianSpock, do you think you'd want to do that?

@SyrianSpock
Copy link
Copy Markdown
Contributor Author

@alext-mkrs Sure, I'll do it ASAP.

@alext-mkrs
Copy link
Copy Markdown
Contributor

Thanks and no rush 😄 I just believe this is a better way to go and looking at the code and @arfoll's comments I think it will increase its chances for merging.

Copy link
Copy Markdown
Contributor

@arfoll arfoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to use _replace API before can be merged

@alext-mkrs
Copy link
Copy Markdown
Contributor

So @SyrianSpock, would you be willing to modify this one as requested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants