Replace IOUtils, part1 #1098#1100
Conversation
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
It's a lot to review, and the formatting adds to the noise.
In principle it's good, but bad things might be hiding in the details.
| if (rootDir.exists()) { | ||
| FileUtils.forceDelete(rootDir); | ||
| } | ||
| FileUtils.forceMkdir(rootDir); |
There was a problem hiding this comment.
gerrit connector
For me, the key question is what to connect to with it and whether it will be possible for me with all the connection restrictions that we are currently facing in different regions.
There was a problem hiding this comment.
There is also the discussion in #567 about maybe splitting out the gerrit, and some other connectors, into it's own repository
There was a problem hiding this comment.
oops, fixed.
@merks do you have more comments regarding this?
|
It looks like the build failure was an infrastructure problem. I tried restarting it just now. |
gnl42
force-pushed
the
1098-replace-ioutils
branch
from
3517ee2 to
43a5a6e
Compare
3 participants
First half of replacing IOUtils with native java
Task-Url: #1098