Skip to content

Added support for Admonition Blocks#1101

Open
azoitl wants to merge 1 commit into
eclipse-mylyn:mainfrom
azoitl:admonitionBlock
Open

Added support for Admonition Blocks#1101
azoitl wants to merge 1 commit into
eclipse-mylyn:mainfrom
azoitl:admonitionBlock

Conversation

@azoitl
Copy link
Copy Markdown
Contributor

@azoitl azoitl commented May 10, 2026

Admonition blocks now also generate the correct preview. The generated HMTL is corresponding the a default AsciiDocktor output. So that it can later be styled with an appropriate CSS file.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 10, 2026

Test Results

 1 629 files  + 3   1 629 suites  +3   1h 13m 43s ⏱️ - 9m 58s
 5 340 tests +13   5 254 ✅ +13   79 💤 ±0  3 ❌ ±0   4 🔥 ±0 
13 505 runs  +35  13 249 ✅ +35  235 💤 ±0  9 ❌ ±0  12 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit df3b099. ± Comparison against base commit c3a9151.

♻️ This comment has been updated with latest results.

@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 11, 2026

It looks like this is an build failure unrelated to my changes. Can someone please retrigger the checks?

@merks
Copy link
Copy Markdown
Contributor

merks commented May 11, 2026

Blindly trying to rerun the jobs...

@merks
Copy link
Copy Markdown
Contributor

merks commented May 11, 2026

There do seem to be failing test. Hard to see the details on my phone.

@gnl42
Copy link
Copy Markdown
Contributor

gnl42 commented May 11, 2026

@BeckerFrank
Failed to discover any fixtures for kind jenkins with defaultOnly=true (https://mylyn.local/ and https://mylyn.frank-becker.de)/

and the gitlab server is returning extra data

org.eclipse.mylyn.gitlab.core.test.RestfulGitlabClientTest.testgetConfiguration -- Time elapsed: 1.633 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 

@azoitl azoitl marked this pull request as draft May 11, 2026 19:00
@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 11, 2026

I just learned that I should have implemented the content handling for admonitions block with a nesting protocol. Therefore I converted this to a draft. Sorry for the generated noise.

@azoitl azoitl force-pushed the admonitionBlock branch from 753aa43 to d48b1ae Compare May 13, 2026 19:36
@azoitl azoitl marked this pull request as ready for review May 13, 2026 19:38
@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 13, 2026

Now also nested lists work inside. There is still one minor problem that you can have headlines and underline headlines inside of admonition blocks. To be honest in any nested blocks. This makes not always sense however currently there is no API to tell the markdown editor that a block can not be nested.

Nonetheless I think it is ready for review and improves the current asciidoc editor a lot.

@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 20, 2026

Still this unrelated tests are failing. Can I do something about it? Can someone retrigger the build?

@merks
Copy link
Copy Markdown
Contributor

merks commented May 20, 2026

Force push an amended commit message.

@azoitl azoitl force-pushed the admonitionBlock branch from ed8428e to 577f262 Compare May 20, 2026 20:33
@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 20, 2026

Force push an amended commit message.

So simple and still so smart. Thx.

@merks
Copy link
Copy Markdown
Contributor

merks commented May 21, 2026

Force push an amended commit message.

So simple and still so smart. Thx.

Yes, I thought I can redo it for you, but easier if you can always do a self-serve instead. 😁

Admonition blocks now also generate the correct preview. The generated
HMTL is corresponding the a default AsciiDocktor output. So that it can
later be styled with an appropriate CSS file.
@azoitl azoitl force-pushed the admonitionBlock branch from 577f262 to df3b099 Compare May 21, 2026 11:57
@azoitl
Copy link
Copy Markdown
Contributor Author

azoitl commented May 21, 2026

Force push an amended commit message.

So simple and still so smart. Thx.

Yes, I thought I can redo it for you, but easier if you can always do a self-serve instead. 😁

It is always better if I don't need to bother anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants