Added support for Admonition Blocks#1101
Conversation
Test Results 1 629 files + 3 1 629 suites +3 1h 13m 43s ⏱️ - 9m 58s For more details on these failures and errors, see this check. Results for commit df3b099. ± Comparison against base commit c3a9151. ♻️ This comment has been updated with latest results. |
|
It looks like this is an build failure unrelated to my changes. Can someone please retrigger the checks? |
|
Blindly trying to rerun the jobs... |
|
There do seem to be failing test. Hard to see the details on my phone. |
|
@BeckerFrank and the gitlab server is returning extra data |
|
I just learned that I should have implemented the content handling for admonitions block with a nesting protocol. Therefore I converted this to a draft. Sorry for the generated noise. |
|
Now also nested lists work inside. There is still one minor problem that you can have headlines and underline headlines inside of admonition blocks. To be honest in any nested blocks. This makes not always sense however currently there is no API to tell the markdown editor that a block can not be nested. Nonetheless I think it is ready for review and improves the current asciidoc editor a lot. |
d48b1ae to
ed8428e
Compare
|
Still this unrelated tests are failing. Can I do something about it? Can someone retrigger the build? |
|
Force push an amended commit message. |
So simple and still so smart. Thx. |
Yes, I thought I can redo it for you, but easier if you can always do a self-serve instead. 😁 |
Admonition blocks now also generate the correct preview. The generated HMTL is corresponding the a default AsciiDocktor output. So that it can later be styled with an appropriate CSS file.
It is always better if I don't need to bother anyone. |
Admonition blocks now also generate the correct preview. The generated HMTL is corresponding the a default AsciiDocktor output. So that it can later be styled with an appropriate CSS file.