Adding the server URL to the invitation code using “@”. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to my email address, I closed this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
It can temporarily overwrite oct.serverUrl by writing the
invitation code@URL.And “https://” can be omitted, and “http://” can be omitted if “@@” is used.
It is the roomId that is entered in joinroom, but due to the structure of connecting to the server using userToken and then entering the room with the roomId, it was necessary to re-store it in the userToken.
Also, in joinroom, the inputbox was displayed after connecting to the server withConnectionProvider, but we changed the order to withConnectionProvider according to the inputbox, I also changed the location of withConnectionProvider.