Skip to content

fix(webui): improve mobile menu item link styling for better usability#1598

Merged
netomi merged 5 commits into
eclipse-openvsx:masterfrom
llinq:style/improve-mobile-menu-usability
Feb 24, 2026
Merged

fix(webui): improve mobile menu item link styling for better usability#1598
netomi merged 5 commits into
eclipse-openvsx:masterfrom
llinq:style/improve-mobile-menu-usability

Conversation

@llinq

@llinq llinq commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

MR relates to #965

@netomi

netomi commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

can you sign the ECA as explained here: https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1598

@llinq

llinq commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

Hello, done @netomi, thanks for reply :)

@netomi

netomi commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

@gnugomez could you take a look?

@gnugomez gnugomez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llinq what's the intention of this patch?

I don't really see any visual difference by applying your changes.

@llinq

llinq commented Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

@gnugomez this change expands the clickable area of the mobile menu link to cover the entire list item.

Currently, only the label itself is clickable, which makes interaction harder (especially on mobile devices). With this update, the whole list item becomes clickable, significantly improving usability and touch accessibility.

This change was motivated by issue #965 which appears to be directly related to this behavior.

Before (current behavior) After (with this change)

@gnugomez

gnugomez commented Feb 11, 2026

Copy link
Copy Markdown
Member

gotcha @llinq , I now see the benefit, although it doesn’t fully solve the issue. Adding a width of 100% is a somewhat clumsy solution, and the corners are still not working correctly, plus you are not fixing the logout form. I believe that the best approach here would be to use MUI Component prop.

@gnugomez

Copy link
Copy Markdown
Member

@llinq could you add me to your fork so that I can push the changes?

@llinq

llinq commented Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi @gnugomez, I agree with your suggestion, thanks!
I’ve sent you the invitation, let me know if I can help with anything else.

@gnugomez gnugomez force-pushed the style/improve-mobile-menu-usability branch from 9d59cb2 to 353ba56 Compare February 11, 2026 16:51
@gnugomez gnugomez force-pushed the style/improve-mobile-menu-usability branch from 353ba56 to cf9bd4c Compare February 24, 2026 09:41
@gnugomez

Copy link
Copy Markdown
Member

@netomi this fix should be g2g, can you take a look?

@netomi

netomi commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

tested the PR, in general it works great, however there is this discrepancy with the current version:

image

compared to current version:

image

@netomi

netomi commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

I pushed a fix for that

@netomi netomi merged commit bbd4e65 into eclipse-openvsx:master Feb 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants