feat(admin): improve user management page #1847
Merged
netomi merged 19 commits intoJun 26, 2026
Merged
Conversation
gnugomez
requested review from
autumnfound and
netomi
and removed request for
netomi
netomi
reviewed
May 19, 2026
autumnfound
reviewed
May 19, 2026
netomi
force-pushed
the
gnugomez/main/admin-users
branch
from
7cd5179 to
5c92aeb
Compare
Contributor
|
I would prefer that there is an additional select box to query for the role, similar to searching for an extension instead of an filter that you apply on the results |
Assisted-By: anthropic:claude-opus-4-7[1m]
… update Assisted-By: github:claude-opus-4.6, github:claude-sonnet-4.6, anthropic:claude-opus-4-7[1m]
gnugomez
force-pushed
the
gnugomez/main/admin-users
branch
from
2f2ba32 to
85c3ff8
Compare
… alert when role change succeeded
netomi
approved these changes
Jun 26, 2026
netomi
left a comment
netomi
left a comment
Contributor
There was a problem hiding this comment.
LGTM, some small changes from myside:
- rename AdminUsers and AdminUsersResult to more meaningful names
- add an info alert when the user role change succeeded that automatically closes
- do not set the role in the UserJson by default, there is at least one endpoint that allows any user to search for other users, and we do not want to expose the role there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1786
Assisted-By: github:claude-opus-4.6, github:claude-sonnet-4.6, anthropic:claude-opus-4-7[1m]