Skip to content

Task: Download test extensions#1971

Merged
netomi merged 2 commits into
eclipse-openvsx:mainfrom
cstamas:downloadTestExtensions
Jul 14, 2026
Merged

Task: Download test extensions#1971
netomi merged 2 commits into
eclipse-openvsx:mainfrom
cstamas:downloadTestExtensions

Conversation

@cstamas

@cstamas cstamas commented Jul 14, 2026

Copy link
Copy Markdown
Member

Rewrite

@netomi

netomi commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

looks good, can we download the test extensions somewhere other than the build dir? this is a long standing annoyance for me as this would delete them when you clean the build.

@cstamas
cstamas requested a review from netomi July 14, 2026 16:08
@cstamas
cstamas marked this pull request as ready for review July 14, 2026 16:12
@cstamas cstamas changed the title Download test extensions Task: Download test extensions Jul 14, 2026
@cstamas

cstamas commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

We could add another (local, non checked in) directory to .gitignore and download there? That way, it could be not checked in... or unsure, does Gradle have some cache usable in this case?

Or, we could use Toolbox for this, as it uses Maven Local Repository as cache.
Nope, these are not artifacts, sorry, mixed up.

@netomi

netomi commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

a separate directory that is added to .gitignore sounds the best solution to me.

cstamas added 2 commits July 14, 2026 19:19
A git ignored directory to use as cache for VSX files.
@cstamas
cstamas force-pushed the downloadTestExtensions branch from 2d46fca to e556471 Compare July 14, 2026 17:26
@cstamas

cstamas commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Pushed, pls test

@netomi
netomi merged commit f3ed307 into eclipse-openvsx:main Jul 14, 2026
5 checks passed
@cstamas
cstamas deleted the downloadTestExtensions branch July 14, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants