Skip to content

Clean Code for ds/org.eclipse.pde.ds.ui#2179

Open
eclipse-pde-bot wants to merge 2 commits into
masterfrom
clean-code/ds/org.eclipse.pde.ds.ui
Open

Clean Code for ds/org.eclipse.pde.ds.ui#2179
eclipse-pde-bot wants to merge 2 commits into
masterfrom
clean-code/ds/org.eclipse.pde.ds.ui

Conversation

@eclipse-pde-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-eca-validation

Copy link
Copy Markdown

Hi @eclipse-pde-bot — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(committer).
  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(author).

To resolve this, please:

  1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
  2. Ensure your GitHub username is linked to your Eclipse account
  3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

1 similar comment
@eclipse-eca-validation

Copy link
Copy Markdown

Hi @eclipse-pde-bot — thank you for your contribution!

The Eclipse Contributor Agreement (ECA) check has failed for this pull request due to one of the following reasons:

  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(committer).
  • An Eclipse Contributor Agreement is required for Eclipse user 'genie.pde'(author).

To resolve this, please:

  1. Sign in or create an Eclipse Foundation account: https://accounts.eclipse.org/user/eca
  2. Ensure your GitHub username is linked to your Eclipse account
  3. Complete and submit the ECA form

Once done, push a new commit (or rebase) to re-trigger the ECA validation.

If you believe you've already completed these steps, please double-check your account settings or report an issue to Eclipse Foundation Helpdesk.

Thanks again for your contribution!

@eclipse-pde-bot

eclipse-pde-bot commented Jan 17, 2026

Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From db7f3dc7d4bf37c15f4a8dffa0f5f6773860b972 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 5 Jun 2026 03:37:47 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/ds/org.eclipse.pde.ds.ui/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.ui/META-INF/MANIFEST.MF
index 1db92fa9ec..39ebfb5ed7 100644
--- a/ds/org.eclipse.pde.ds.ui/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.ds.ui;singleton:=true
-Bundle-Version: 1.4.300.qualifier
+Bundle-Version: 1.4.400.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ds.ui.Activator
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.30.0,4.0.0)",
  org.eclipse.core.resources;bundle-version="[3.20.0,4.0.0)",
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Jan 17, 2026

Copy link
Copy Markdown

Test Results

 66 files   -    60   66 suites   - 60   35s ⏱️ - 34m 4s
133 tests  - 3 377  133 ✅  - 3 323  0 💤  -  54  0 ❌ ±0 
510 runs   - 8 823  510 ✅  - 8 693  0 💤  - 130  0 ❌ ±0 

Results for commit 48f05bd. ± Comparison against base commit af2b487.

This pull request removes 3377 tests.
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test1
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test2
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test3
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test4
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test5
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test6
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingAnalysisAntTaskTests ‑ test7
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test1
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test2
org.eclipse.pde.api.tools.anttasks.tests.ApiToolingApiFreezeAntTaskTests ‑ test3
…

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch 2 times, most recently from 58ad065 to f0f6654 Compare January 20, 2026 08:43
@vogella

vogella commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Most like the same issue as here described here for the manual process #2115

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch from 5ab2e00 to a5e48ad Compare January 20, 2026 13:46
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch 3 times, most recently from 3f41879 to a13dd3a Compare March 6, 2026 03:25
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch from d313287 to 236f455 Compare April 28, 2026 03:26
@laeubi laeubi force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch from 236f455 to 8fb08da Compare June 3, 2026 04:54
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch from b9428d2 to 2a071c6 Compare June 4, 2026 03:31
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.ui branch from ed92aa5 to be84892 Compare June 5, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants